Replace 0xFF characters with escaped hex (\xFF) #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make sure that the areas with .replace work properly and double check that the file encoding remained as ANSI in your commit? Also, would be great to get some across the board testing of various scripts to ensure there are no bugs introduced by this change. Apart from that, I think this is a good change and will accept the pull request upon completion of testing. |
|
can someone test this change? |
|
wasn't it included in the #228 ? |
|
@mf2212 that pr was never merged |
|
Loving this. Would appreciate it =) |
Closed
ryancrunchi
pushed a commit
to ryancrunchi/d2bot-with-kolbot
that referenced
this pull request
Dec 30, 2018
Replace 0xFF characters with escaped hex (\xFF)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Characters for message coloring (0xFF) aren't recognized properly by some of the editors. This results in broken message coloring after modifying the files. By using \xFF sequence instead, this problem doesn't happen.